search

ocaml / flexdll

a dlopen-like API for Windows
Other
98 stars 30 forks source link

Prevent MSVC displaying .c filename when compiling #15

Closed dra27 closed 8 years ago

dra27 commented 8 years ago

See also https://github.com/ocaml/ocaml/pull/407.

alainfrisch commented 8 years ago

Thanks!

dra27 commented 8 years ago

Ah - we're working too quickly - something's failing in the testsuite run... give me a minute!

dra27 commented 8 years ago

(sorry, I thought enough of the testsuite had run...)

alainfrisch commented 8 years ago

Is that a problem with the PR on flexdll, or the one in OCaml?

dra27 commented 8 years ago

This one on FlexDLL - I accidentally shadowed a variable, but it doesn't pick up when building OCaml because it never exercises ocamlc -custom (I thought I'd gone past the relevant test in the testsuite before submitting the PR)

dra27 commented 8 years ago

I'm just (properly) testing the actual fix - do you want me to push an additional PR, or will you reset to HEAD~1 on master (never thought I'd write that!)

alainfrisch commented 8 years ago

I prefer an additional PR.

dra27 commented 8 years ago

OK - immortalise my embarrassing errors, why don't you :wink: It's done - but I'm allowing a full testsuite run before opening the PR this time!