Fix errors in previous attempt to silence MSVC

ocaml / flexdll

a dlopen-like API for Windows

Other

98 stars 30 forks source link

Fix errors in previous attempt to silence MSVC #16

Closed dra27 closed 8 years ago

dra27 commented 8 years ago

Correct fix this time!

alainfrisch commented 8 years ago

Is it intentional to not show the content of the redirected stdout in case of error?

dra27 commented 8 years ago

No!

dra27 commented 8 years ago

That should deal with that (I'm just about to run it) - but one other question. I don't think it's my regression, but in dry_mode, should it be compiling the file??

alainfrisch commented 8 years ago

but in dry_mode, should it be compiling the file??

No, of course!

dra27 commented 8 years ago

I wasn't sure, given how it works (automatically compiling an intermediate) - in which case, I'll fix that while I'm here!

dra27 commented 8 years ago

There we go - that should fix that too. x86 and x64 builds and testsuite presently running...

dra27 commented 8 years ago

That all seems to be fine

alainfrisch commented 8 years ago

Thanks!