search

ocaml / flexdll

a dlopen-like API for Windows
Other
98 stars 30 forks source link

Remove implicit field name in record constructions #20

Closed dra27 closed 8 years ago

dra27 commented 8 years ago

Don't use the let field = () in {field} feature (3.12.0 onwards)

dra27 commented 8 years ago

I'd like to maintain packages where flexlink is compiled in older OCamls. The most invasive change is not using OCaml 3.12.0's implicit record field names feature. This one would be useful to have in master, as it affects far more lines of code, increasing the likelihood of the patch needing regenerating over time... The rest requires not using {|...|} in cmdline.ml and inserting some Bytes-related compatibility declarations in coff.ml but I imagine you're not particularly interested in those two changes?

alainfrisch commented 8 years ago

Well, I don't want to commit to maintaining compatibility with older OCamls, but if you feel like doing so, I'll certainly accept such PRs.