ocaml / flexdll

a dlopen-like API for Windows
Other
98 stars 30 forks source link

Fix sources tarball #26

Closed dra27 closed 7 years ago

dra27 commented 7 years ago

There is a mistake in Makefile from when my findwinsdk script was added - it needs to be included in the sources tarball.

This patch fixes Makefile for future versions - please could you regenerate the .tar.gz file on your website for 0.35 (or just add the findwinsdk script to it)?

alainfrisch commented 7 years ago

Did you find any public link to that .tar.gz? The README now points to source releases created by GitHub.

dra27 commented 7 years ago

I guessed it - the OPAM packages I've put together use the ones from your website. Are they deprecated?

alainfrisch commented 7 years ago

I haven't given it much thought, but GitHub tarballs are rather convenient, and they are the ones currently advertised in the README; I'm not sure I will continue to upload .tar.gz to my server.

dra27 commented 7 years ago

In which case, would it be best to remove the tarball lines completely from Makefile?

alainfrisch commented 7 years ago

I'm rather tempted to merge this PR and postpone this decision.

dra27 commented 7 years ago

In postponing, please could the findwinsdk file be added to the tarball too - then I can also postpone updating the opam files :wink:

alainfrisch commented 7 years ago

I've updated the uploaded tarball, although I'm not sure you can get away without updating the opam file (which contains a md5sum of the tar.gz, no?).

dra27 commented 7 years ago

Thanks - that means I just update the 0.35 opam file... if the switch to GitHub tarballs becomes official, there're the 0.29-0.34 ones to update too! 2 I can cope with, 14 on the other hand...

dra27 commented 7 years ago

I just tried it - unfortunately you've added the file to the root, rather than in flexdll-0.35/. This'll fix it:

gunzip flexdll-0.35.tar.gz
tar -xf flexdll-0.35.tar findwinsdk
tar -f flexdll-0.35.tar --delete findwinsdk
tar -rf flexdll-0.35.tar --transform="s|^|flexdll-0.35/|" --remove-files findwinsdk
gzip flexdll-0.35.tar
alainfrisch commented 7 years ago

Oops, fixed.

dra27 commented 7 years ago

Marvellous, ta!