search

ocaml / flexdll

a dlopen-like API for Windows
Other
98 stars 30 forks source link

On MSVC, link libfoo.lib or foo.lib for -lfoo #32

Closed dra27 closed 6 years ago

dra27 commented 7 years ago

This is related to https://github.com/ocaml/ocaml/pull/1189, please see the full description of the motivation there!

alainfrisch commented 7 years ago

I'm not sure to understand exactly the relation with ocaml/ocaml#1189. Is the PR on ocaml still relevant if the current PR on flexdll is accepted?

dra27 commented 7 years ago

Sorry for the lag. Both these are PRs are relevant - ocaml/ocaml#1189 only applies this heuristic ocamlmklib; this PR allows applies the same heuristic to ocamlc and ocamlopt (which of course just pass -l options on to the linker - in this case, flexlink).

dra27 commented 6 years ago

Sorry for the delay addressing the PR point - would it be possible for this to go in and release 0.36 be cut so that 4.06 can declare it as a minimum requirement? It would be good for the special-case treatment of -l to be in sync. It's also of course worth getting a version out including #40)

alainfrisch commented 6 years ago

I've created 0.36. I'm not sure about binary releases, though. Previous versions where built with the mingw (32-bit) port of OCaml, which means (i) the resulting flexlink.exe had no dependency on msvcrXXX.dll (good!), but (ii) it was limited by the size of strings in 32-bit OCaml processes (bad!). I think that these days, one can safely assume that OCaml developers under Windows are using a 64-bit OS. Do you agree? So mingw64?

As for the runtime support objects, the msvc32/64 ones were built with a very old version of VS (VS2008 I think), and they would not work with recent versions. Do you have a suggestion?

dra27 commented 6 years ago

Perhaps best to include two versions of flexlink.exe in the binary - 32 and 64? Perhaps have the main one being 64-bit and a subdirectory x86 containing the 32-bit version? I've been using 64-bit since Windows Vista, but you never know...

Not sure how @damiendoligez would feel about our changing the build process for FlexDLL during the 4.06 cycle (so moving to requiring the user to supply the flexdll.c and flexdll_initer.c and a binary flexlink.exe vs providing the object files). I see three options:

  1. "status quo" - binary release as normal (using VS2008) and assume VS 2015/2017 users will either grumble or know to recompile
  2. Include the .c files and ensure that running make support is well-documented (both in OCaml and in FlexDLL)
  3. Change the process in OCaml so that byterun/Makefile expects to find flexdll.c and flexdll_initer.c with flexdll.h and compiles and installs them itself. The compiler would still expect flexlink.exe to be provided (unless you're bootstrapping flexlink, of course).

I like 3, but I can't implement it in the next 24 hours!

alainfrisch commented 6 years ago

Perhaps best to include two versions of flexlink.exe in the binary - 32 and 64? Perhaps have the main one being 64-bit and a subdirectory x86 containing the 32-bit version?

Do you see an advantage of that over creating two binary releases/installers (which seems rather common under Windows)?

For 2: do you mean, including both the .c files and the Makefile, so that users (with a Cygwin environment) can run "make support" on their side?

A variant could be to add to flexlink.exe the ability to compile its support files (from the .c files found in the same directory as flexlink.exe) using the compilers currently in the PATH. E.g. "flexlink -toolchain msvc -prepare-runtime -o foo/" would create the support objects under foo/.

dra27 commented 6 years ago

Either way for the distribution works fine - for a graphical installer, yes, it'd be more normal to have two (I've never installed flexlink that way!).

Yes, that is what I meant for 2 - on the assumption that the user has a Cygwin environment because they're just about to compile OCaml. That of course assumes that any Windows binary distribution of OCaml therefore includes FlexDLL (kinda true, but only by coincidence!).

Not sure about having flexlink being able to spit out the runtime objects - would you then expect ocamlc/ocamlopt to run as necessary, or expect the user to have done it beforehand?

alainfrisch commented 6 years ago

would you then expect ocamlc/ocamlopt to run as necessary, or expect the user to have done it beforehand?

The OCaml's build system (resp. the future ./configure for Windows) would generate the runtime objects, and install them together with OCaml libraries.

dra27 commented 6 years ago

Ah, OK - so it's similar to what I propose in 3, but in a more structured manner - OCaml simply invokes a command which tells flexlink to output its objects, rather than assuming that it can compile the .c files itself. Nice!