Be more forgiving with relative paths in search dirs

ocaml / flexdll

a dlopen-like API for Windows

Other

97 stars 30 forks source link

Be more forgiving with relative paths in search dirs #88

Closed yakobowski closed 2 years ago

yakobowski commented 4 years ago

If a search dir is relative and starts by '..', the current code is going to crash. Instead, accept it without normalizing it.

yakobowski commented 2 years ago

To answer your question, yes we saw this crashing. However we are building in a very specific env:

regular MinGW compiler (i.e. not the "cross" one from Cygwin)
tons of systems libraries at non-standard paths. So I cannot extract a repro case, I'm afraid.

yakobowski commented 2 years ago

I rebased and pushed a minor variation which does not use when. Apologies for the back-and-forth.

dra27 commented 2 years ago

Thank you for swift update! That looks great to me. No problem about the repro - I was only curious as to whether you'd got a "real" setup which hit this, or if you'd just noticed it reading the code.

I shall shortly tag 0.40, which will include this.