search

ocaml / merlin

Context sensitive completion for OCaml in Vim and Emacs
https://ocaml.github.io/merlin/
MIT License
1.59k stars 233 forks source link

vim: remove references to MerlinPhrase #1804

Closed paparodeo closed 4 months ago

paparodeo commented 4 months ago

MerlinPhrase calls an undefined function, vim_selectphrase, in the python code. This function was removed some years ago in change 8ebe7ff71ed367f814ca399cb1328f02f5c9d976. Remove all references to MerlinPhrase in the help docs, keybindings and vim functions which call it.

https://github.com/ocaml/merlin/commit/8ebe7ff71ed367f814ca399cb1328f02f5c9d976#diff-836f8a63886b2c63a113a107540d42a0b3a6272b016b2d45fb5bcffd99a708b4L754

it looks like it was re-implemented by https://github.com/ocaml/merlin/commit/89526e8e6ae19c07a628ca9fceb7f2f9cb98f894 with new (undocumented) vim bindings to merlin#PhrasePrev and merlin#PhraseNext

voodoos commented 4 months ago

Could you add a changelog entry ?

voodoos commented 4 months ago

Thank you !