search

ocaml / ocaml-ci-scripts

Skeletons for CI scripts
ISC License
101 stars 57 forks source link

FreeBSD support in .travis-ocaml.sh #331

Closed cyrilst closed 4 years ago

cyrilst commented 4 years ago

Hello, here is a PR for FreeBSD support in .travis-ocaml.sh

I tried it successfully with https://github.com/geneweb/geneweb (OCAML_VERSION=4.05)

kit-ty-kate commented 4 years ago

I looked around a bit and couldn't find any documentation saying that Travis now supports FreeBSD. Could you provide the appropriate documentation and add FreeBSD to the list of tested distribution in the travis.yml file?

cyrilst commented 4 years ago

Indeed, travis documentation is not yet up to date (discussion here : https://github.com/travis-ci/travis-build/pull/1780 )

I've just lauched a travis run with freebsd, we'll see if it's ok…

cyrilst commented 4 years ago

Looks like all tests passed without problems (one mac os test had to be restarted, but it's unrelated) : https://travis-ci.org/github/cyrilst/ocaml-ci-scripts

XVilka commented 4 years ago

I am not sure about FreeBSD in Travis, but we use SourceHut for FreeBSD and OpenBSD (NetBSD support WIP also), see https://github.com/ocaml/ocaml-ci-scripts/issues/307

kit-ty-kate commented 4 years ago

I'll let CI running and this PR should be good to go now.

cc @hannesm and @mato, this might interest you in the short term.

cyrilst commented 4 years ago

Awesome, thank you!

kit-ty-kate commented 4 years ago

ok let's try! Thanks!

hannesm commented 4 years ago

this is great, thanks for your contribution. It'd be even better if the support would be mentioned in the documentation (README-travis.md has a section ### Testing on different OS which could be extended).

cyrilst commented 4 years ago

That's totally right: https://github.com/ocaml/ocaml-ci-scripts/pull/334