search

ocaml / ocaml-ci-scripts

Skeletons for CI scripts
ISC License
101 stars 57 forks source link

Fix travis-docker for the new ocaml/opam images #349

Closed kit-ty-kate closed 4 years ago

tmcgilchrist commented 4 years ago

Thanks for this fix, I thought I'd broken something in my CI setup @kit-ty-kate :-)

hannesm commented 4 years ago

I can see some failures with this PR now merged. Some repositories specify e.g.: DISTRO=alpine, which used to work previously. Now, this fails (since there's no such ocaml/opam:alpine-ocaml-4.10 image available).

A successful CI job before this commit was https://travis-ci.org/github/mirage/ocaml-freestanding/jobs/742979019 -- the failing job is https://travis-ci.org/github/mirage/ocaml-freestanding/builds/743448545

I do not understand entirely which (and why) certain tags of ocaml/opam are available (i.e. which ocaml versions does ocaml/opam:alpine contain?), but I'd prefer to not break users of the CI scripts -- or emit a warning on such a misconfiguration (docker container no longer present / maintained). WDYT?