Fix abs_pos computing in `String_zipper.drop_until`

emilienlemaire commented 5 months ago

This PR should fix a problem that occurs when editing a text document with apply_text_document_edits, where some text could be duplicated, as shown in #1207.

coveralls commented 5 months ago

Pull Request Test Coverage Report for Build 4250

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 21.189%

Totals
Change from base Build 4249:	0.0%
Covered Lines:	5147
Relevant Lines:	24291

💛 - Coveralls

rgrinberg commented 5 months ago

Thanks for the fix. In fact, this PR is two independent fixes and I would like tests for each individual fix separately. The abs_pos fix is in fact not covered by the tests, as you can see here: https://github.com/ocaml/ocaml-lsp/pull/1280

EDIT: managed to add a separate test for abs_pos management

rgrinberg commented 5 months ago

Thanks!

ocaml / ocaml-lsp