coveralls
commented
3 months ago Pull Request Test Coverage Report for Build 4292
Details
- 45 of 47 (95.74%) changed or added relevant lines in 2 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.08%) to 21.87%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| ocaml-lsp-server/src/code_actions/action_destruct_line.ml | 44 | 46 | 95.65% | ||
| <!-- | Total: | 45 | 47 | 95.74% | --> |
| Totals | |
|---|---|
| Change from base Build 4285: | 0.08% |
| Covered Lines: | 5369 |
| Relevant Lines: | 24550 |
Fixed a bug where destruct-line would sometimes fail to provide the "-> _" on the right-hand side of cases when Merlin split its response across multiple lines.
Used the opportunity to clean up how the reply gets formatted: it now relies on fewer fragile regular expressions and should generally be a bit easier to read.
Testing also led to the discovery of some bad behavior on case-lines where the lhs is a hole, but the cursor isn't on the hole. This was fixed by adding
OffsetHoleto thestatement_kindvariants.Testing
Updated the expect-tests for long variant names, offset-holes, and hole-spacing. Importantly, the tests called "destruct strips parentheses even on long lines" and "destruct a case with a hole but not on the hole" confirm the bug-fixes.