Closed PizieDust closed 1 month ago
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
ocaml-lsp-server/src/custom_requests/req_get_documentation.ml | 28 | 41 | 68.29% | ||
<!-- | Total: | 28 | 41 | 68.29% | --> |
Totals | |
---|---|
Change from base Build 4448: | 0.2% |
Covered Lines: | 5571 |
Relevant Lines: | 25444 |
Approved! Thanks a lot @PizieDust!
Thanks for the reviews
@rgrinberg Do you want to make one last pass?
The implementation looks fine. @awilliambauer do you want to take a look at the docs? Is this something that you will be able to use?
This looks reasonable to me, and useful for providing documentation-focus functionality.
closes #1319
Add
documentation
custom query.