ocaml / ocaml-lsp

OCaml Language Server Protocol implementation
Other
749 stars 117 forks source link

Documentation custom query #1336

Closed PizieDust closed 1 month ago

PizieDust commented 1 month ago

closes #1319

Add documentation custom query.

coveralls commented 1 month ago

Pull Request Test Coverage Report for Build 4469

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details


Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/custom_requests/req_get_documentation.ml 28 41 68.29%
<!-- Total: 28 41 68.29% -->
Totals Coverage Status
Change from base Build 4448: 0.2%
Covered Lines: 5571
Relevant Lines: 25444

💛 - Coveralls
PizieDust commented 1 month ago

Approved! Thanks a lot @PizieDust!

Thanks for the reviews

xvw commented 1 month ago

@rgrinberg Do you want to make one last pass?

rgrinberg commented 1 month ago

The implementation looks fine. @awilliambauer do you want to take a look at the docs? Is this something that you will be able to use?

awilliambauer commented 1 month ago

This looks reasonable to me, and useful for providing documentation-focus functionality.