coveralls
commented
1 month ago Pull Request Test Coverage Report for Build 4447
Details
- 28 of 53 (52.83%) changed or added relevant lines in 6 files are covered.
- 8 unchanged lines in 2 files lost coverage.
- Overall coverage decreased (-0.03%) to 21.726%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| ocaml-lsp-server/src/custom_requests/req_hover_extended.ml | 1 | 2 | 50.0% | ||
| ocaml-lsp-server/src/custom_requests/req_wrapping_ast_node.ml | 0 | 1 | 0.0% | ||
| ocaml-lsp-server/src/custom_requests/util.ml | 3 | 7 | 42.86% | ||
| ocaml-lsp-server/src/custom_requests/req_typed_holes.ml | 0 | 5 | 0.0% | ||
| ocaml-lsp-server/src/custom_requests/req_type_enclosing.ml | 9 | 15 | 60.0% | ||
| ocaml-lsp-server/src/custom_requests/req_merlin_call_compatible.ml | 15 | 23 | 65.22% | ||
| <!-- | Total: | 28 | 53 | 52.83% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| ocaml-lsp-server/src/custom_requests/req_hover_extended.ml | 1 | 51.72% | ||
| ocaml-lsp-server/src/custom_requests/req_merlin_call_compatible.ml | 7 | 65.08% | ||
| <!-- | Total: | 8 | --> |
| Totals | |
|---|---|
| Change from base Build 4443: | -0.03% |
| Covered Lines: | 5519 |
| Relevant Lines: | 25403 |
rgrinberg
xvw
The patch proposes a global pass on Custom Requests by trying to impose the
module Request_paramsstructure, which proposes a creation function (and projection in Yojson), and atype tat the module toplevel (with a conversion function from Yojson).Custom_requestmodule is exposed byOcaml_lsp_serverfor use from, for example, tests (and also from a JavaScript client, ie: vscode).I'm obviously open to feedback!