search

ocaml / ocaml.org

The official OCaml website.
https://ocaml.org
Other
161 stars 320 forks source link

Feat/events rss feed #2437

Closed ishar19 closed 4 months ago

ishar19 commented 5 months ago

Resolves #2392

ishar19 commented 5 months ago

Hey @ishar19, this looks awesome! ✨

Here's some things to consider to make this useful for posting updates to social media, and to be useful in RSS readers:

  • the start date of the event should be included in its title
  • instead of using the summary element to hold the location, I would instead use the content element to render the same information that is listed on the event card. Summary element can be omitted.
  • we cannot use the URL to the actual event as atom:id: "The content of an atom:id element MUST be created in a way that assures uniqueness." (see https://www.rfc-editor.org/rfc/rfc4287#section-4.2.6). Using the slug of the event together with its date should be sufficiently unique.

Hey @sabine thanks for the review and insights and recommended changes, let me make those and get back to this Thanks!

ishar19 commented 4 months ago

so sorry for delay, i was out for a gateway, will try to wrap this up by 2-3 days

ishar19 commented 4 months ago

hey @sabine i have updated the format, please take a look. Thanks

image
cuihtlauac commented 4 months ago

We've just merged a PR #2461 which contains generic RSS feed creation logic that could be used here.

ishar19 commented 4 months ago

We've just merged a PR #2461 which contains generic RSS feed creation logic that could be used here.

just saw it, looks really nice, shall i refactor this to use that logic?

sabine commented 4 months ago

Ah yes, that would be awesome!

ishar19 commented 4 months ago

Ah yes, that would be awesome!

sure thing, will do that ASAP @sabine , thanks for the heads up!

ishar19 commented 4 months ago

Closing this one with link to new PR #2495