search

ocaml / ocaml

The core OCaml system: compilers, runtime system, base libraries
https://ocaml.org
Other
5.19k stars 1.06k forks source link

FreeBSD amd64: emit .note.GNU-stack same as on Linux #13103

Closed kostikbel closed 2 weeks ago

kostikbel commented 3 weeks ago

The lack of the annotation causes PT_GNU_STACK requesting executable stack on amd64 FreeBSD.

Another not quite cosmetic consequence is that not too old GNU ld.bfd complains about lack of the note. This breaks almost half of the test suite on FreeBSD.

nojb commented 3 weeks ago

Could you add a Changes entry as well? Thanks!

nojb commented 3 weeks ago

Also @haesbaert

kostikbel commented 3 weeks ago

Could you add a Changes entry as well? Thanks!

Done.

hannesm commented 3 weeks ago

I think this is fine. Maybe worth to backport to 4.14 branch!? I haven't tested it, and won't be able to test it this month. But I'm sure your CI systems will complain if it is wrong.

nojb commented 3 weeks ago

I tested this on precheck, which passed: https://ci.inria.fr/ocaml/job/precheck/970/flambda=false,label=ocaml-freebsd-64

kostikbel commented 2 weeks ago

Ping?

nojb commented 2 weeks ago

Ping?

Sorry, I dropped the ball on this one. Will merge once CI passes (took the liberty of fixing some conflicts with trunk).