Closed dra27 closed 1 day ago
Sorry for the lag. Dropping the clean statement was in my mind, but apparently I then didn't do it, so thanks for that one.
For flexdll, the $(ROOTDIR)/flexdll
wasn't originally an accident, but it wasn't doing that for winpthreads ... and I decided I prefer your version anyway, so I've pulled that commit straight in, thank you!
Gabriel Scherer (2024/05/15 02:50 -0700):
Merged #13112 into trunk.
Thanks. In general I'd be happy to get a chance to review these things.
This PR collects a whole load of related tweaks together which started from some checking done in #13093.
configure.ac
which I should have put in #10135 originally.configure.ac
andMakefile
for these two submodules - i.e.configure.ac
stops generatingMakefile
-fragments and simply emits strings, like it's supposed to..gitignore
entry we missed in #12954 (we also missed cleaningwinpthreads-sources
indistclean
which is fixed a few commits later).yacc/wstr.obj
(a Windows-specific object) didn't work because it relies onMakefile.build_config
which isn't loaded in a clean target. That's also a bit of meta-programming / layer violation between configure/make which I'm not terribly fond of, but I don't have a better solution to hand at the moment.12976 accidentally broke the ability to run
make distclean
from an unconfigured tree.make clean
ought to clean theflexdll
objects, which is done in the next commit (it's only morally becausemake clean
does clean the flexlink executable and for reasons of history flexdll's Makefile always compiles by specifying the.ml
files on the command line, rather than the more traditional separate compilation and linking, so flexlink was always completely recompiled after amake clean
)..obj
files. I've fixed that by instead putting the winpthreads objects inruntime/winpthreads
during the build.cc @shindere, @shym, @MisterDA 🙂