search

ocaml / ocaml

The core OCaml system: compilers, runtime system, base libraries
https://ocaml.org
Other
5.5k stars 1.11k forks source link

Reorder major_gc.c into coherent blocks #13627

Open NickBarnes opened 1 day ago

NickBarnes commented 1 day ago

This PR simply reorders the functions (and some variables) in runtime/major_gc.c into sections of related functionality, and adds some banner comments identifying each section. It does not add or remove anything.

The first commit reorders things (a simple sort < before > a ; sort < after > b ; diff a b should be reassuring that there are no other changes). The second commit adds banner comments.

This is intended to make future work on the major GC easier, and quicker to review, by localising it within the file (For example, some forthcoming work on the ephemerons code).

NickBarnes commented 1 day ago

The main in-progress work I'm aware of, at least on trunk, is my #13580 and @damiendoligez's work on GC pacing. This work was originally on my local branch for #13580 (as part of an attempt to address the problem with orphaned ephemerons, detected there by multicoretests). I have separated it here so it can be reviewed separately, and in particular rejected if either @damiendoligez or @stedolan object. Conflicts will of course be created with ocaml-flambda/flambda-backend; if this PR gets merged I'll rapidly create a corresponding one there. Hopefully not too many other forks are making major changes to major_gc.c.

gasche commented 1 day ago

I propose to wait a few days to see if @damiendoligez or @stedolan object -- I would be surprised given their mean latency -- and then go ahead and merge.