Propagate -keep-locs and -keep-docs in all compiler invocations

[gasche]

Fixes #256

[jacquev6]

Thanks! That was quick :)

[jacquev6]

That was quick but this doesn't work :-/ Using the gist I linked in #256, after path-pinning the keep-locs-docs branch:

$ ./do.sh 
/home/vincent/.opam/4.05.0/bin/ocamldep.opt -keep-docs -pp -keep-docs -modules Content.mli > Content.mli.depends
+ /home/vincent/.opam/4.05.0/bin/ocamldep.opt -keep-docs -pp -keep-docs -modules Content.mli > Content.mli.depends
/home/vincent/.opam/4.05.0/bin/ocamldep.opt: unknown option '-keep-docs'.

Looks like adding flag ["ocaml"; "pack"; "keep_docs";] (A "-keep-docs"); and flag ["ocaml"; "pack"; "keep_locs";] (A "-keep-locs"); would work.

[gasche]

Indeed. I tried to go for a broader scope of flag application to avoid under-shooting, but I forgot about the ocamldep invocation. I need a new iteration and a testing strategy. Thanks!

[jacquev6]

Thank you for your time!

[gasche]

I updated the patch.

I would like to write a testsuite but I don't know of any easy-to-implement way to automate the check that keep-loc is passed (within our current testsuite). The only thing I found was that if I compile a pack from several modules, then edit one of the .mli to add a new empty line at the start, then location changes and the hash of the result packed .cmi should change as a result. But our testsuite encourages us to perform a single build action and observe the result (or build error), so this is impractical. I think I will leave this without a unit test.

[jacquev6]

Thanks! I'm using it with

opam pin add ocamlbuild https://github.com/gasche/ocamlbuild.git#keep-locs-docs

and everything looks fine.

[gasche]

Merged, thanks a lot for the report and feedback.