search

ocaml / ocamlbuild

The legacy OCamlbuild build manager
Other
121 stars 81 forks source link

Remove two checks of Pathname.is_implicit #279

Closed charlesetc closed 6 years ago

charlesetc commented 6 years ago

This is an attempt to address issue #152. I wanted to share this code and bump #152 in general. It'd be great to allow passing absolute paths to -I in ocamlbuild.

I have very little familiarity with ocamlbuild's source and absolutely no confidence that these are the right changes to make. These changes do allow a local ocamlbuild to build with relative include paths on my computer, and all the tests pass :paintbrush:

charlesetc commented 6 years ago

I think these changes are buggy when using absolute paths, so I'm closing this PR. I hope absolute paths are possible someday

gasche commented 6 years ago

I hadn't got around to looking in depth at your code yet, apologies. (It did look a bit surprising on a first skim.)

I'm not terribly optimistic about ways to extend ocamlbuild to support absolute paths, because of the way we rely on relative paths being re-interpreted in a different way in _build/ (compared to the project root).

I think that if your workflow would strongly benefit from a change here, you might be better off evaluating alternative build systems. In particular, dune/jbuilder, who is actively developed and should succeed to ocamlbuild, could be a reasonable option.

charlesetc commented 6 years ago

Ah well I guess that makes sense — thanks very much anyways!