search

ocaml / ocamlbuild

The legacy OCamlbuild build manager
Other
121 stars 81 forks source link

Add a tests for long commands #344

Closed hhugo closed 2 months ago

hhugo commented 2 months ago

Add a test that we can handle commands bigger that 8k characters. Fix the windows implementation that previously had a 8K limit.

hhugo commented 2 months ago

On windows, the limit seems to be ~8185 which seems very close to the 8192 character limit imposed by CMD.EXE. Yet, we're not longer supposed to go through cmd.exe. @dra27, any idea where the current limit could be coming from ?

hhugo commented 2 months ago

With this PR, I believe we now have all important piece of code of fdopen's patches. The maintenance of ocamlbuild can return to its previous state :)

hhugo commented 2 months ago

With this PR, I believe we now have all important piece of code of fdopen's patches. The maintenance of ocamlbuild can return to its previous state :)

To be more explicit, there are still things present in fdopen patches and absent from upstream but I don't think they are necessary.