search

ocaml / ocamlbuild

The legacy OCamlbuild build manager
Other
121 stars 81 forks source link

Add macos to the CI #349

Closed hhugo closed 2 months ago

hhugo commented 2 months ago

I don't understand the relation between the +unix changes on OCaml 4 and the macos testing.

ld complain/warn about inexistant directory in search path ld: warning: search path '/Users/runner/work/ocamlbuild/ocamlbuild/_opam/lib/ocaml/unix' not found

https://github.com/ocaml/ocamlbuild/actions/runs/9678830233/job/26703462729

gasche commented 2 months ago

@kit-ty-kate you probably encountered this issue when you dealt with the new-install-directories transition. (Apparently in the code we decided to unconditionally use the new layout.) Could you by chance confirm that the conditional logic proposed by @hhugo is the best approach?

hhugo commented 2 months ago

@gasche, the layout change was made by myself in https://github.com/ocaml/ocamlbuild/pull/328

gasche commented 2 months ago

Oh, I hadn't realized this and maybe we should have been more careful in #328, but the combined diff makes sense.