ocaml / odoc

Documentation compiler for OCaml and Reason
Other
322 stars 89 forks source link

Failed to resolve module path identifier #1083

Open zapashcanon opened 8 months ago

zapashcanon commented 8 months ago

Hi,

When applying this change to Owi, I got the following:

$ dune b @doc
File "../../src/.owi.objs/byte/owi.odoc":
Warning: Failed to resolve module path identifier((root Owi__Symbolic_value).{Bool}1, true) Lookup failure (module): (root Owi__Symbolic_value).{Bool}1

This may be similar to #789 but I'm not completely sure.

jonludlam commented 8 months ago

Can you please see if applying PR #1081 helps at all? It looks to me like it's looking up a shadowed value which doesn't work well in master - that PR might fix it.

zapashcanon commented 8 months ago

I don't see the warning anymore with this patch indeed!

jonludlam commented 8 months ago

Good news, thanks for checking!

zapashcanon commented 4 months ago

@jonludlam I believe this can be closed, right ? :)