ocaml / odoc

Documentation compiler for OCaml and Reason
Other
322 stars 89 forks source link

Add an upper-bound constraint on OCaml #1199

Closed kit-ty-kate closed 3 days ago

kit-ty-kate commented 1 week ago

odoc doesn't currently have an upper-bound constraint on its dependency towards OCaml. However it's a near certainty that it will be broken by the next version of the compiler.

To avoid myself and others having to do double the work in opam-repository (e.g. https://github.com/ocaml/opam-repository/pull/26640) I would encourage you to add the upper-bound constraints on your packages in both master and 2.4 branch

kit-ty-kate commented 3 days ago

Thanks! Could it be backported to the 2.4 branch as well just in case?

Julow commented 3 days ago

Yes: https://github.com/ocaml/odoc/pull/1201 Thanks for the issue :)

kit-ty-kate commented 3 days ago

ah sorry i missed that PR. Thanks!