Closed SquidDev closed 2 years ago
Hi! Thanks for this work :)
It will take me some time to carve out time for a review, but I have it on my queue! Hopefully over the weekend.
I'm afraid I've caused a merge conflict as I'm cleaning up the backlog of PRs. I think I should be able to resolve this without causing any extra work on your side, @SquidDev.
Sorry for the slow review cycle, but thank you very much for bringing this up to date, and for the cleanup on the parser :)
This also refactors how entities are parsed, meaning there's only one function to do it (rather than two). I'm not 100% with the changes I've made to the parser combinator and
Sub
modules - happy to discuss those.