ocaml / omd

extensible Markdown library and tool in "pure OCaml"
ISC License
156 stars 45 forks source link

Update spec to 0.30 #266

Closed SquidDev closed 2 years ago

SquidDev commented 2 years ago

This also refactors how entities are parsed, meaning there's only one function to do it (rather than two). I'm not 100% with the changes I've made to the parser combinator and Sub modules - happy to discuss those.

shonfeder commented 2 years ago

Hi! Thanks for this work :)

It will take me some time to carve out time for a review, but I have it on my queue! Hopefully over the weekend.

shonfeder commented 2 years ago

I'm afraid I've caused a merge conflict as I'm cleaning up the backlog of PRs. I think I should be able to resolve this without causing any extra work on your side, @SquidDev.

shonfeder commented 2 years ago

Sorry for the slow review cycle, but thank you very much for bringing this up to date, and for the cleanup on the parser :)