Closed tatchi closed 2 years ago
That's a good idea, @sonologico. Perhaps we could followup with a refactor to clean up that massive file at some point soon :)
Will wait to review here until it's been rebased/updated to account for the work its based on.
Will wait to review here until it's been rebased/updated to account for the work its based on.
It's rebased 😊
Perfect, surgical fix here. We’ll diagnosed! Thanks :)
Input:
The current result in master:
There are two issues here:
Labels are not being matched, hence it is not recognized as a link. This is what I fixed in https://github.com/ocaml/omd/pull/277. I included that change in the first commit.
The url destination is not percent encoded. From the spec:
And `ASCII control characters are:
I'm not sure why
'\x80' .. '\x9F'
were being matched since, according to the spec, they're not considered as an `ASCII control characters. Removing them from the pattern fixes the test and doesn't break any other so I guess that's fine.Fix #272