ocaml / opam-repository

Main public package repository for opam, the source package manager of OCaml.
https://opam.ocaml.org
Creative Commons Zero v1.0 Universal
509 stars 1.1k forks source link

packages not available on windows because they embed an oasis configu… #26144

Closed hhugo closed 5 days ago

hhugo commented 1 week ago

…re script broken on windows

hhugo commented 1 week ago

This one should be easy to merge.

mseri commented 6 days ago

Can you paste here a protypical error message?

mseri commented 6 days ago

Ping @jonahbeckford, is that ok dkml-wise?

jonahbeckford commented 6 days ago

This doesn't seem like a Windows problem. It is just failing because the lack of shell/configure support on whichever Windows machine was tested.

So, without me having to do parallel testing on every opam package, the exclude from all Windows is too broad.

hhugo commented 6 days ago

This is definitely a windows issue, these packages have their setup file generated from an old oasis version. The issue come from the following code that give the wrong location to ocamlbuild library

let fix_args args extra_argv =
    List.flatten
      [
        if (os_type ()) = "Win32" then
          [
            "-classic-display";
            "-no-log";
            "-no-links";
            "-install-lib-dir";
            (Filename.concat (standard_library ()) "ocamlbuild")
          ]
        else

Ocamlbuild is no longer installed as a sub directory of the stdlib.

jonahbeckford commented 6 days ago

Ah, thanks for correcting me. Definitely applies to all Windows machines. Disable it!

mseri commented 5 days ago

Thanks for the clarifications and for checking