ocaml / opam-repository

Main public package repository for opam, the source package manager of OCaml.
https://opam.ocaml.org
Creative Commons Zero v1.0 Universal
516 stars 1.12k forks source link

[new release] ocaml_libbpf (2 packages) (0.1.0) #26176

Closed koonwen closed 3 months ago

koonwen commented 3 months ago

Libbpf bindings

CHANGES:
raphael-proust commented 3 months ago

Hiya,

Thanks for the contribution! There are a few things I'd like to address before merging.

First, we don't recommend using the "ocaml" in the name of packages. See https://github.com/ocaml/opam-repository/wiki/Policies#7-new-package-names-should-avoid-the-ocaml-prefixsuffix for an explanation. Would it be ok to rename your package to something like libbpf-bindings or similar?

Second, we tend to split the part of the pacakge that declares the depexts and the part that declares the code. This is for practical reasons: the two parts tend to evolve at a different pace: a user might contribute a line to the depexts to add support for their distribution, you might want to do a new release of the bindings, the two changes would benefit from each other if they are in separate packages. Can you make a conf-libbpf package for the system pacakge instalation?

Both of these points have exceptions that can apply. If there is a specific reason you think your package should be treated differently than the general case, let us know.

koonwen commented 3 months ago

Hi @raphael-proust, thanks for the response! Sure those look like reasonable and easy changes to make, let me address them and then make a new PR release