ocaml / opam-repository

Main public package repository for opam, the source package manager of OCaml.
https://opam.ocaml.org
Creative Commons Zero v1.0 Universal
516 stars 1.12k forks source link

opass + core incompatibility #422

Closed avsm closed 11 years ago

avsm commented 11 years ago

The Core incompatibility begins here :) /cc @orbitz

+ ocamlfind ocamlc -c -g -annot -thread -package str,core,core_extended,sexplib.syntax,bin_prot.syntax,comparelib.syntax,fieldslib.syntax,variantslib.syntax -syntax camlp4o -I bin -I lib -o bin/main.cmo bin/main.ml
File "bin/main.ml", line 289, characters 7-37:
Error: This function expects too many arguments, it should have type
string -> unit

This is on 3.12.1:

 - install ocamlfind.1.3.3 [required by opass]
 - install ounit.1.1.2 [required by opass]
 - install pcre-ocaml.6.2.5 [required by opass]
 - install res.3.2.0 [required by opass]
 - install type_conv.108.07.01 [required by opass]
 - install bin_prot.108.07.01 [required by opass]
 - install comparelib.108.07.01 [required by opass]
 - install fieldslib.108.07.01 [required by opass]
 - install pa_ounit.108.07.01 [required by opass]
 - install pipebang.108.07.01 [required by opass]
 - install sexplib.108.07.01 [required by opass]
 - install variantslib.108.07.01 [required by opass]
 - install core.108.07.01 [required by opass]
 - install core_extended.108.07.01 [required by opass]
orbitz commented 11 years ago

I'm going to regret saying I'm ok with Core changing fast, aren't I?

I'll work on updating opass code this week. As much as I love Makefiles I also have to fix the build system to be more ocaml-friendly but retain the directory layout I like.

avsm commented 11 years ago

@orbitz, any chance of an update to the existing opass package with the right version constraints? That'll at least stop the autobuilder from screaming at me every morning.

orbitz commented 11 years ago

@avsm whoops! I didn't realize this was causing you daily pain, I'll fix this tonight.

orbitz commented 11 years ago

@avsm What is the preferred solution here? To specify which version of Core is required to install opass or to make separate opass tags for each version of Core?

avsm commented 11 years ago

Just the range of versions on which you expect it to work is fine (in this case, probably an upper bound)

avsm commented 11 years ago

Closed with the pull #443