Fix opam tree --test --doc assigning the with-{test,doc} variables to unrequested packages

ocaml / opam

opam is a source-based package manager. It supports multiple simultaneous compiler installations, flexible package constraints, and a Git-friendly development workflow.

https://opam.ocaml.org

Other

1.21k stars 348 forks source link

Fix opam tree --test --doc assigning the with-{test,doc} variables to unrequested packages #5919

Closed kit-ty-kate closed 2 months ago

kit-ty-kate commented 3 months ago

Fix https://github.com/ocaml/opam/issues/5755 Fix https://github.com/ocaml/opam/issues/5920

OpamSwitchState.universe was called with ~requested:st.installed so all the packages that were currently installed had their with-doc, with-test, with-dev-setup and dev variables assigned instead of just the packages that were given as input to the opam tree command.

~TODO:~

[x] ~add a test (see https://github.com/ocaml/opam/issues/5755#issuecomment-1921773756)~

kit-ty-kate commented 2 months ago

All cleaned up, squashed and ready to go.