Change default rule for `PKG_CONFIG_PATH` and `MANPATH` to `target`

ocaml / opam

opam is a source-based package manager. It supports multiple simultaneous compiler installations, flexible package constraints, and a Git-friendly development workflow.

https://opam.ocaml.org

Other

1.24k stars 353 forks source link

Change default rule for `PKG_CONFIG_PATH` and `MANPATH` to `target` #5972

Closed dra27 closed 3 months ago

dra27 commented 4 months ago

Neither of these systems supports quoting (on Windows or Unix).

This should address the regression in #5923, but it's not the final fix for Windows, so that issue should stay open after this is merged.

cc @RyanGibb

dra27 commented 3 months ago

The switch to Host restores the MANPATH revert and gets us to:

set MANPATH=:/cygdrive/c/Users/DRA/AppData/Local/opam/testing-mingw/man

on Cygwin, and

set MANPATH=:/c/Devel/Roots/msys2-testing/testing/man

on MSYS2, which should be correct. i.e. the directories are colon-separated, but are converted using cygpath.

kit-ty-kate commented 3 months ago

Thanks!