search

ocaml / opam

opam is a source-based package manager. It supports multiple simultaneous compiler installations, flexible package constraints, and a Git-friendly development workflow.
https://opam.ocaml.org
Other
1.21k stars 348 forks source link

Adjust common flags passed to Cygwin setup #6046

Closed dra27 closed 2 days ago

dra27 commented 1 week ago

Fixes #6041 - an additional option might be to explicitly abort when run non-interactively as well, but it's getting a bit niche because if you're non-interactive and expecting depext to work with an external Cygwin then clearly you must have specified --confirm-level unsafe-yes.

Backport into 2.2 in #6057

dra27 commented 1 week ago

It turns out that this can be solved in setup-ocaml by ensuring that Cygwin's setup registry key is restored as part of the action. I'm therefore not certain that we have to do this for 2.2.0

dra27 commented 1 week ago

This is no longer required for 2.2.0 - the adjustments in it are probably worth including in 2.2.1, however.

dra27 commented 1 week ago

Oh dear, I appear to need to U-turn! There is an issue with this which probably is worth addressing for 2.2.0 - if the user happens to end up even interactively with an external Cygwin which needs input, then we've turned the dialogues off, which is bad.

I've added a commit to use --quiet-mode unattended for external Cygwin, keeping --quiet-mode noinput for the internal installation only, where we know that all the inputs have been provided.