ocaml / opam

opam is a source-based package manager. It supports multiple simultaneous compiler installations, flexible package constraints, and a Git-friendly development workflow.
https://opam.ocaml.org
Other
1.21k stars 348 forks source link

Restore signature of OpamStateConfig.opamroot #6047

Closed dra27 closed 2 days ago

dra27 commented 1 week ago

5457 changed the signature of OpamStateConfig.opamroot between beta2 and beta3 which has broken the opam-dune-lint plugin along with a few other packages. This seems a shame, given that it's quite trivial and indeed natural to have two functions and simply have the provenance-returning version have a new name.

Given that it looks like we'll need an rc2 to deal with the Cygwin hangit's a demonstrably safe internal API restoration, I'm hoping we can slip this API change in at the same timeto the final release. If we do, https://github.com/ocaml/opam-repository/pull/26066 can be reverted.

Backported into 2.2 in #6058