ocaml / tuareg

Emacs OCaml mode
GNU General Public License v3.0
360 stars 79 forks source link

3.0 version not tagged #283

Closed bbatsov closed 1 year ago

bbatsov commented 2 years ago

According to the changelog it was released on 2021-09-20. Not sure if the changelog is wrong or someone forgot to properly tag a release. The package metadata heading says 2.3 currently.

bbatsov commented 2 years ago

Btw, the displayed version is even more incorrect:

image

I think it should be extracted from the package metadata instead of being duplicated in this string.

monnier commented 2 years ago

I just pushed a patch which uses package-get-version to get the "real" info in Emacs≥27. Regarding 2.3 -vs- 3.0 I'll let the real maintainers decide what should be done.

bbatsov commented 2 years ago

I've also noticed that the release notes for 2.3 are missing here https://github.com/ocaml/tuareg/releases. I'm not sure if anyone besides @Chris00 can fix this.

Chris00 commented 1 year ago

I've also noticed that the release notes for 2.3 are missing

This is because there is no 2.3 version and 3.0 has not yet been formally released.

bbatsov commented 1 year ago

@Chris00 Notice the package header, though:

image

If there was no 2.3 it should probably say something else. I like to use snapshot versions between releases (e.g. 3.0.0-snapshot) and that's a pretty common practice in general.

Chris00 commented 1 year ago

I agree. It was updated with the idea of making a release shortly after but the latter did not materialize...

bbatsov commented 1 year ago

@Chris00 The problem is that ELPA cuts releases automatically when you change the version here (to something looking like a stable version) and there's actually a 2.3 release in NonGNU ELPA already because of this https://elpa.nongnu.org/nongnu/tuareg.html

Perhaps it'd be prudent to tag whatever ended up there as 2.3.0 on Git and bump the version number to 3.0.0-snapshot to account for this?

Chris00 commented 1 year ago

I've done so. (The problem with having several unrelated release systems...)