Closed bbatsov closed 2 years ago
Remove the old Travis badge as well?
@mattiase My bad! It's removed now.
Fine, thanks (but someone else needs to merge).
Guess so.
@mattiase My bad! It's removed now.
LGTM except the patch also removes trailing double spaces, which are
needed for proper rendering (they're hard-linebreaks, and there's
actually one missing at the end of the sample.ml
line).
@monnier Would you be ok with turning this to a listing, as suggested in the commit that I added? (that's how this is normally done in Markdown, as using trailing indentation for line breaks is super brittle)
@monnier Would you be ok with turning this to a listing, as suggested in the commit that I added? (that's how this is normally done in Markdown, as using trailing indentation for line breaks is super brittle)
I don't have much opinion about that (I like trailing whitespace about as much as I like the extra bullets with the new syntax), so I merged your change, thanks.
@monnier Btw, it seems the PR is still open.
@monnier Btw, it seems the PR is still open.
Duh! Pushed to the wrong place, thanks.
Thanks! 🙇♂️
It was still pointing to Travis and now the project uses GitHub Actions.