ocaml / tuareg

Emacs OCaml mode
GNU General Public License v3.0
362 stars 79 forks source link

Fix the CI badge #289

Closed bbatsov closed 2 years ago

bbatsov commented 2 years ago

It was still pointing to Travis and now the project uses GitHub Actions.

mattiase commented 2 years ago

Remove the old Travis badge as well?

bbatsov commented 2 years ago

@mattiase My bad! It's removed now.

mattiase commented 2 years ago

Fine, thanks (but someone else needs to merge).

bbatsov commented 2 years ago

Guess so.

monnier commented 2 years ago

@mattiase My bad! It's removed now.

LGTM except the patch also removes trailing double spaces, which are needed for proper rendering (they're hard-linebreaks, and there's actually one missing at the end of the sample.ml line).

bbatsov commented 2 years ago

@monnier Would you be ok with turning this to a listing, as suggested in the commit that I added? (that's how this is normally done in Markdown, as using trailing indentation for line breaks is super brittle)

monnier commented 2 years ago

@monnier Would you be ok with turning this to a listing, as suggested in the commit that I added? (that's how this is normally done in Markdown, as using trailing indentation for line breaks is super brittle)

I don't have much opinion about that (I like trailing whitespace about as much as I like the extra bullets with the new syntax), so I merged your change, thanks.

bbatsov commented 2 years ago

@monnier Btw, it seems the PR is still open.

monnier commented 2 years ago

@monnier Btw, it seems the PR is still open.

Duh! Pushed to the wrong place, thanks.

bbatsov commented 2 years ago

Thanks! 🙇‍♂️