search

ocaml / v2.ocaml.org

Implementation of the ocaml.org website.
http://ocaml.org
Other
323 stars 346 forks source link

Improve https://ocaml.org/meetings/ page #1315

Open nibble0101 opened 3 years ago

nibble0101 commented 3 years ago

Currently when you navigate to the meetings page, there are strange characters in the text under the Ocaml meetings > In Europe section. Check the screenshot below at the end of the lines.

image

When you switch to the French page and translate it to English, you will see the header Upcoming Events having an event which was held last year. Check the screenshot below.

image

Further down still on the French page, you will seeOcaml meetings and meetings. It is worth pointing out that this is a translation from French to English. It could therefore be a mis-translation. Check the screenshot below.

image

When you compare the English and French page, they look quite different and there seems to be differences in content and styling. In my opinion the French page looks better with the side navigation.

nibble0101 commented 3 years ago

@patricoferris and @avsm. Could this be within the scope of #1245 or good first issue?

PS. I am not an applicant

gurleennsidhuu commented 3 years ago

Hi. Can you please help me understand this a little more? Do we have to add a side navigation to the English page + remove the extra characters at the end?

nibble0101 commented 3 years ago

@gurleennsidhuu It is great that you have registered interest in working on the issue. My opinion is yes but it is advisable to wait for what @patricoferris or @avsm thinks before you start working on it. Nevertheless it shouldn't stop you from exploring.

I think the following are worth fixing:

  1. Remove the stray characters
  2. Transfer the outdated event under upcoming events to past events
  3. Make the English page look like French page if it doesn't become too much for a good first issue
patricoferris commented 3 years ago

Thanks again @nibble0101 your contributions here have been nothing short of superb!

@gurleennsidhuu feel free to tackle this issue, to keep it manageable I would focus on (1) and (2) for now unless you feel capable to handle the translations.

gurleennsidhuu commented 3 years ago

Hi. Does this look fine? (1) meet (2) past I left the "Upcoming events" column empty. Should I delete the heading or leave it empty?

gurleennsidhuu commented 3 years ago

Can I create a new issue for making the English page look like the French page?

gurleennsidhuu commented 3 years ago

Hi @patricoferris and @avsm. Looking forward to your response. :)

pitag-ha commented 3 years ago

@gurleennsidhuu , have you already worked on (1) and (2)?

gurleennsidhuu commented 3 years ago

@gurleennsidhuu , have you already worked on (1) and (2)?

Yes.

Hi. Does this look fine? (1) meet (2) past I left the "Upcoming events" column empty. Should I delete the heading or leave it empty?

Can you please confirm if this is correct?

gurleennsidhuu commented 3 years ago

Should I keep the 'Prochains evenements' section empty or should I remove it?

pitag-ha commented 3 years ago

Maybe we could do it as on the English page? Do you speak French?

gurleennsidhuu commented 3 years ago

Maybe we could do it as on the English page? Do you speak French?

I think the English page doesn't have past and upcoming events section and no, I don't speak or know French.

pitag-ha commented 3 years ago

Yeah, I also think in English that's only one section, so we could do the same in French. But I don't know how to tranlsate that to French

gurleennsidhuu commented 3 years ago

Maybe we could do it as on the English page? Do you speak French?

Can we use google translator?

pitag-ha commented 3 years ago

I don't think Google translator would a a good idea: we might end up choosing a wrong translation.

gurleennsidhuu commented 3 years ago

I don't think Google translator would a a good idea: we might end up choosing a wrong translation.

I talked to one of my friends who knows French and according to her the google translation 'Atelier utilisateurs et développeurs OCaml' for OCaml Users and Developers Workshop is correct.