search

ocamllabs / ocaml-effects

*DEPRECATED: See ocaml-multicore/ocaml-multicore* OCaml effects handlers
Other
27 stars 4 forks source link

remove ocamlbuild -- to conform with other 4.03 switches #18

Closed gasche closed 8 years ago

gasche commented 8 years ago

Because of the separate-ocamlbuild transition that happens in 4.03, the opam metadata now expect OCaml version <4.03 to provide ocamlbuild, and >=4.03 not to. In the current state of the master branch, I find myself unable to install merlin once the switch is installed (maybe this means that the constraints I added on base-ocamlbuild to enforce <4.03 is wrong and should be lifted; I assumed that experimental switches would follow trunk in removing ocamlbuild).

The present patch removes ocamlbuild from this switch, so that the separate ocamlbuild package (0.9.1 currently) can be installed.

P.S.: In my local clone I merged the "master" branch of the repo back into effects-native, because I prefer to work from a branch with an informative name. Is this something you plan to do anyway, or is the semantic that "master" is experimental while "effects-native" tracks a known-not-too-broken state?

kayceesrk commented 8 years ago

Excellent! Thanks for the PR. Regarding the naming of branches, master is the correct branch while effects-native is a stale branch.