search

ocapmod / ocap-legacy

OCAP is a game-changing tool that allows the recording and playback of operations on an interactive (web-based) map.
Other
38 stars 42 forks source link

Loading Data Prompt #29

Closed skarphet closed 8 years ago

skarphet commented 8 years ago

Would be useful with a loading data prompt - we just had a 2 hour operation with 70~ players and the JSON takes a while to load. It just makes the screen go blank.

I'll try to send a pull request for this within a day or two. It may have been added already but I haven't seen it yet, at least.

skarphet commented 8 years ago

Looking at ocap.js, I found the following: https://github.com/mistergoodson/OCAP/blob/master/web/scripts/ocap.js#L872-L876

However, this modal never actually appears to be visible or it is the main modal and it simply disappears right after clicking, kind of defeating the point. Is this intended design?

JamieGoodson commented 8 years ago

Good spot. The modal is supposed to display that message, then hide it after processOp is complete. However, since processOp is asynchronous, it hides the message almost immediately after showing it. I've modified the script to now display this correctly (see 361bcaa).