search

ocbe-uio / BayesMallows

R-package for Bayesian preference learning with the Mallows rank model.
https://ocbe-uio.github.io/BayesMallows/
GNU General Public License v3.0
21 stars 9 forks source link

Update based on some recent developments #379

Closed osorensen closed 6 months ago

osorensen commented 6 months ago

@wleoncio the CodeFactor issues look like false positives to me, since the code it is referring to is in work-docs. Do you know how we can make CodeFactor ignore everything in that directory?

wleoncio commented 6 months ago

Sure, we could add something like this to the top level (no indent) of codecov.yml

ignore:
    - "work-docs"
wleoncio commented 6 months ago

Strange. Maybe CF is not even reading the config file? 🤔

wleoncio commented 6 months ago

Just edited https://www.codefactor.io/repository/github/ocbe-uio/bayesmallows/ignore accordingly, maybe that'll do it.

bilde

osorensen commented 6 months ago

Could it be so that it checks the config file that is on the master branch??

wleoncio commented 6 months ago

Could it be so that it checks the config file that is on the master branch??

I'm not even sure it's reading any file at all. On my other projects I don't even have a config file for CodeFactor 😅

wleoncio commented 6 months ago

Anyway, we can address all code smells on a different PR, I'll review the code now.

osorensen commented 6 months ago

Thanks @wleoncio! I added #382 which is a simple fix.

wleoncio commented 6 months ago

No problem, looks good. We'll fight CodeFactor later...