search

ocbe-uio / BayesMallows

R-package for Bayesian preference learning with the Mallows rank model.
https://ocbe-uio.github.io/BayesMallows/
GNU General Public License v3.0
21 stars 9 forks source link

Have website follow CRAN releases #380

Closed osorensen closed 6 months ago

osorensen commented 6 months ago

I'm a fan of having the latest development version in the master branch on GitHub, and then having the releases on CRAN. This is how, e.g., all the tidyverse packages seem to be doing it. However, since pushing to the master branch triggers the website to be built, this means that the website will not document the CRAN version.

There seems to be a fix to this here: https://r-pkgs.org/website.html#development-mode

@wleoncio, would you have the capacity to look into this within the next month or so?

wleoncio commented 6 months ago

Sure thing, I got no plans for vinterferie 😅

But isn't it simpler to just remove L4-L7 on pkgdown.yaml so the build is only triggered on updates to GitHub releases (which are tracking the ones on CRAN)?

https://github.com/ocbe-uio/BayesMallows/blob/a1d3ee857fdfb5fc0a3934c82db5507788fbeecb/.github/workflows/pkgdown.yaml#L3-L9

Edit: for a list of other valid activity types for release, see here

osorensen commented 6 months ago

Thanks, that sounds correct! Then I should be able to fix it myself :-)