Closed osorensen closed 6 months ago
Should close #394 and #386
The Linter error is a false positive. It reports on the
library()
statements in this example, but sinceggplot2
is listed inImports
I think it is absolutely fine.R CMD check
does not report on it either.
Alright, but then perhaps we should add those lines to linter.yml so CI doesn't bothers us about it.
The Linter error is a false positive. It reports on the
library()
statements in this example, but sinceggplot2
is listed inImports
I think it is absolutely fine.R CMD check
does not report on it either. https://github.com/ocbe-uio/BayesMallows/blob/35dd003922ac96a19dc340c1f4cbe84f19ba76a8/inst/examples/compute_mallows_sequentially_example.R#L1-L5Alright, but then perhaps we should add those lines to linter.yml so CI doesn't bothers us about it.
Absolutely. I'll add that now.
@wleoncio I think I managed to fix the linter issue, but do you know where CodeFactor gets its settings from?
@wleoncio I think I managed to fix the linter issue, but do you know where CodeFactor gets its settings from?
Unfortunately, that's still a mystery to me 😅
The Linter error is a false positive. It reports on the
library()
statements in this example, but sinceggplot2
is listed inImports
I think it is absolutely fine.R CMD check
does not report on it either.https://github.com/ocbe-uio/BayesMallows/blob/35dd003922ac96a19dc340c1f4cbe84f19ba76a8/inst/examples/compute_mallows_sequentially_example.R#L1-L5