search

ocbe-uio / BayesMallows

R-package for Bayesian preference learning with the Mallows rank model.
https://ocbe-uio.github.io/BayesMallows/
GNU General Public License v3.0
21 stars 9 forks source link

A lot of changes #397

Closed osorensen closed 6 months ago

osorensen commented 6 months ago

The Linter error is a false positive. It reports on the library() statements in this example, but since ggplot2 is listed in Imports I think it is absolutely fine. R CMD check does not report on it either.

https://github.com/ocbe-uio/BayesMallows/blob/35dd003922ac96a19dc340c1f4cbe84f19ba76a8/inst/examples/compute_mallows_sequentially_example.R#L1-L5

osorensen commented 6 months ago

Should close #394 and #386

wleoncio commented 6 months ago

The Linter error is a false positive. It reports on the library() statements in this example, but since ggplot2 is listed in Imports I think it is absolutely fine. R CMD check does not report on it either.

https://github.com/ocbe-uio/BayesMallows/blob/35dd003922ac96a19dc340c1f4cbe84f19ba76a8/inst/examples/compute_mallows_sequentially_example.R#L1-L5

Alright, but then perhaps we should add those lines to linter.yml so CI doesn't bothers us about it.

osorensen commented 6 months ago

The Linter error is a false positive. It reports on the library() statements in this example, but since ggplot2 is listed in Imports I think it is absolutely fine. R CMD check does not report on it either. https://github.com/ocbe-uio/BayesMallows/blob/35dd003922ac96a19dc340c1f4cbe84f19ba76a8/inst/examples/compute_mallows_sequentially_example.R#L1-L5

Alright, but then perhaps we should add those lines to linter.yml so CI doesn't bothers us about it.

Absolutely. I'll add that now.

osorensen commented 6 months ago

@wleoncio I think I managed to fix the linter issue, but do you know where CodeFactor gets its settings from?

wleoncio commented 6 months ago

@wleoncio I think I managed to fix the linter issue, but do you know where CodeFactor gets its settings from?

Unfortunately, that's still a mystery to me 😅