Pairwise preferences now supported for SMC

ocbe-uio / BayesMallows

R-package for Bayesian preference learning with the Mallows rank model.

https://ocbe-uio.github.io/BayesMallows/

GNU General Public License v3.0

21 stars 9 forks source link

Closed osorensen closed 6 months ago

osorensen commented 6 months ago

Tests are missing, hence this is still just a draft.

osorensen commented 6 months ago

Should solve #398 by removing a test, and solve #395, #388, #385.

wleoncio commented 6 months ago

Soooo, is it ready for review now?

wleoncio commented 6 months ago

CodeFactor found an issue: Redundant blank line at the start of a code block should be deleted.

It's currently on: src\missing_data_functions.cpp:32 Commit fc19e4085472c27295d891ee9a2cc26a922a1457

osorensen commented 6 months ago

Soooo, is it ready for review now?

Yes it is. I'll fix the CodeFactor issue