zhizuio
commented
1 week ago Commit 0c2bf18 introduced header file
updateRP_genomic_cpp.hwhich contains lots of global variables that might have been introduced by mistake and should be only internal toupdateRP_genomic_cpp(). If that's the case, internalizing them should make the code more readable (and potentially memory-efficient).
I have doubled checked those variables and can confirm that they are local variables. One possible issue (not very sure if it is an issue) in my original updateRP_genomic_cpp.h might be that it is not recommended to initialise local variables in a function in the header file.
We can keep it as what you have changed. I might change it later on when implementing the issue#21.
In fact, I copied the header file from our R-package psbcSpeedUp in which those variables are shared by multiple functions but defined as private in the class PSBC{}.
Commit 0c2bf18f58e0d3ebfb854c1475f67eb8896e603a introduced header file
updateRP_genomic_cpp.hwhich contains lots of global variables that might have been introduced by mistake and should be only internal toupdateRP_genomic_cpp(). If that's the case, internalizing them should make the code more readable (and potentially memory-efficient).