search

ocbe-uio / DIscBIO

A user-friendly R pipeline for biomarker discovery in single-cell transcriptomics
Other
12 stars 5 forks source link

Networking outputs different network from hyperlink #23

Closed wleoncio closed 3 years ago

wleoncio commented 3 years ago

[20:21, 10.10.2020] Salim Ghannoum: I have just noticed something strange in DIscBIO, the Networking() is giving a network that is not the same as the hyperlink [20:22, 10.10.2020] Salim Ghannoum: You can see that in the binder for MLS or part 2 or part 4 [20:25, 10.10.2020] Salim Ghannoum: I went through the code but could not understand perfectly the part you added, could you please check it when you have time?

wleoncio commented 3 years ago

Hi @SystemsBiologist,

Could you please post code to reproduce the issue? Looking at the output from the notebook, I don't see a difference between the printed network and the linked one (if I understood the problem correctly).

Screenshot from CTC part 2

image

Screenshots from MLS

image

Regarding the part I added

Not sure what you mean, but if it's this part than the only thing it does is reset the par options to R's default after the set_plot_dimentions function is finished. This is a requirement for the CRAN publication (a function is not supposed to alter a user's par settings).

wleoncio commented 3 years ago

Closing by request (log on Teams)