search

ocbe-uio / TruncExpFam

R package to generate data related to the Truncated Exponential Family
https://ocbe-uio.github.io/TruncExpFam/
GNU General Public License v3.0
0 stars 1 forks source link

Increase default max.it? #84

Closed wleoncio closed 2 years ago

wleoncio commented 2 years ago

It seems like the default max.it = 25 on mlEstimationTruncDist() is way too low and might trick users into thinking the estimation has converged (to the wrong values). The unit tests always use at least 500, and I often find myself using 1 000, so I was wondering if the default should be set to one of the latter.

wleoncio commented 2 years ago

Rene's suggestion: 100. Our method is derivative-based and ?optim says " ‘maxit’ The maximum number of iterations. Defaults to ‘100’ for the derivative-based methods, and ‘500’ for ‘"Nelder-Mead"’`.