search

ocbe-uio / contingencytables

Statistical Analysis of Contingency Tables
https://ocbe-uio.github.io/contingencytables/
GNU General Public License v3.0
3 stars 2 forks source link

Chapter 4: Wilson_score_CI_2x2 function missing? #16

Closed wleoncio closed 3 years ago

wleoncio commented 3 years ago

Hi Morten,

While finishing issue #4 (translating Chapter 4 functions), I noticed that the files on http://folk.uio.no/mortenfa/SACT/R/chap4R.zip contain the file Wilson_score_CI_1x2.R, which is also present on the chapter 2 files.

Considering that:

I am seeking confirmation that the R script on chap4R.zip is the wrong one.

If this is indeed the case and the R code for the 2x2 function isn't there, I could translate chap4M.zip/Wilson_score_CI_CC_2x2.m from MATLAB into R, though it would be great to have a few examples (perhaps from the SACT book) so I can make sure the output is correct.

Best, Waldir

mortenfagerland commented 3 years ago

Hi Waldir,

The Wilson_score_CI_1x2 file in chapter 4 is identical to the one in chapter 2. It's there because one or more of the other files in chapter 4 call this function, so it has been copied to chapter 4 to avoid problems for people who only download the chapter 4 files. This will be no problem when everything is packaged together. Just make sure that the files in chapter 4 that need to call the Wilson_score_CI_1x2 function are able to do this :-)

Please let me know if I have explained this badly ;-)

Thanks again for doing this!

Morten

From: Waldir Leoncio @.***> Sent: 13 April 2021 08:49 To: ocbe-uio/contingencytables Cc: Morten Fagerland; Assign Subject: [ocbe-uio/contingencytables] Chapter 4: Wilson_score_CI_2x2 function missing? (#16)

Hi Morten,

While finishing issue #4https://github.com/ocbe-uio/contingencytables/issues/4 (translating Chapter 4 functions), I noticed that the files on http://folk.uio.no/mortenfa/SACT/R/chap4R.zip contain the file Wilson_score_CI_1x2.R, which is also present on the chapter 2 fileshttp://folk.uio.no/mortenfa/SACT/R/chap2R.zip.

Considering that:

I am seeking confirmation that the R script on chap4R.zip is the wrong one.

If this is indeed the case and the R code for the 2x2 function isn't there, I could translate chap4M.zip/Wilson_score_CI_CC_2x2.m from MATLAB into R, though it would be great to have a few examples (perhaps from the SACT book) so I can make sure the output is correct.

Best, Waldir

- You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/ocbe-uio/contingencytables/issues/16, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ5J5VIUEKBN3RYWS3WA7R3TIPSN5ANCNFSM422WS5TQ.

wleoncio commented 3 years ago

Got it, thanks!

ti., 13.04.2021 kl. 03.29 -0700, skrev mortenfagerland:

Hi Waldir,

The Wilson_score_CI_1x2 file in chapter 4 is identical to the one in chapter 2. It's there because one or more of the other files in chapter 4 call this function, so it has been copied to chapter 4 to avoid problems for people who only download the chapter 4 files. This will be no problem when everything is packaged together. Just make sure that the files in chapter 4 that need to call the Wilson_score_CI_1x2 function are able to do this :-)

Please let me know if I have explained this badly ;-)

Thanks again for doing this!

Morten

From: Waldir Leoncio @.***> Sent: 13 April 2021 08:49 To: ocbe-uio/contingencytables Cc: Morten Fagerland; Assign Subject: [ocbe-uio/contingencytables] Chapter 4: Wilson_score_CI_2x2 function missing? (#16)

Hi Morten,

While finishing issue #4https://github.com/ocbe-uio/contingencytables/issues/4 (translating Chapter 4 functions), I noticed that the files on http://folk.uio.no/mortenfa/SACT/R/chap4R.zip contain the file Wilson_score_CI_1x2.R, which is also present on the chapter 2 fileshttp://folk.uio.no/mortenfa/SACT/R/chap2R.zip.

Considering that:

I am seeking confirmation that the R script on chap4R.zip is the wrong one.

If this is indeed the case and the R code for the 2x2 function isn't there, I could translate chap4M.zip/Wilson_score_CI_CC_2x2.m from MATLAB into R, though it would be great to have a few examples (perhaps from the SACT book) so I can make sure the output is correct.

Best, Waldir

- You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/ocbe-uio/contingencytables/issues/16, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQ5J5VIUEKBN3RYWS3WA7R3TIPSN5ANCNFSM422WS5TQ.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/ocbe-uio/contingencytables/issues/16#issuecomment-818630425, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AB62OEETCZ5FHR76EZJX2VTTIQMILANCNFSM422WS5TQ.

wleoncio commented 3 years ago

Adding task to close this issue when completed:

wleoncio commented 3 years ago

Resolved by the commits mentioned above + a3dad3594d5922af566840f4899652d3a4f75121.