Several functions are using global variables as arguments

ocbe-uio / rBAPS

R implementation of the BAPS software for Bayesian Analysis of Population Structure

http://www.helsinki.fi/bsg/software/BAPS/

GNU General Public License v3.0

10 stars 4 forks source link

Several functions are using global variables as arguments #10

Closed wleoncio closed 3 years ago

wleoncio commented 3 years ago

This was an early workaround which is best to be removed. Simply removing them from the argument list (and updating the documentation) should not cause any problems when checking. Those are almost all functions related to the translation of admix1.m. Moreover, leaving it as is is likely to cause bugs.

wleoncio commented 3 years ago

Some links that might help solving environment-related problems (not the tree-kind, though):

http://adv-r.had.co.nz/Environments.html
https://stackoverflow.com/q/63261060/1169233
https://github.com/search?p=1&q=utils%3A%3AglobalVariables&type=Code&utf8=
https://stackoverflow.com/q/65220769/1169233

wleoncio commented 3 years ago

Fixed. Unit tests are failing now, but that's a different issue.