search

occ-ai / obs-backgroundremoval

An OBS plugin for removing background in portrait images (video), making it easy to replace the background when recording or streaming.
GNU General Public License v2.0
2.69k stars 185 forks source link

Background Removal - Update available! #495

Closed Zahrun closed 7 months ago

Zahrun commented 7 months ago

Describe the bug

I get the window "Background Removal - Update available!" even though I am using version 1.1.7, which I believe is the latest.

To Reproduce

Steps to reproduce the behavior:

  1. Install obs-backgroundremoval 1.1.7
  2. Open OBS
  3. See the update available dialog

Expected behavior

Dialog does not show if I am on latest release.

Screenshots

image

Log

2023-12-13 10-53-30.txt

Desktop (please complete the following information):

Zahrun commented 7 months ago

PS: probably need to replace all references to obs-ai with occ-ai https://github.com/occ-ai/obs-backgroundremoval/blob/9a1d13c6784d499f88b1af22e9f3252daf0f3b45/src/update-checker/github-utils.cpp#L11

royshil commented 7 months ago

@Zahrun yes you're absolutely right!

royshil commented 7 months ago

shuold be fixed by #496

royshil commented 7 months ago

@Zahrun are you able to test the latest version with the fix?

Zahrun commented 7 months ago

I see that there is a "Build for Ubuntu" Github action. Where is the artifact?

royshil commented 7 months ago

https://github.com/occ-ai/obs-backgroundremoval/actions/runs/7198176814#artifacts

every master push and every pull request have a build with artifacts

Zahrun commented 7 months ago

@Zahrun are you able to test the latest version with the fix?

Tested and approved.

royshil commented 7 months ago

closing, done