occ-ai / obs-backgroundremoval

An OBS plugin for removing background in portrait images (video), making it easy to replace the background when recording or streaming.
GNU General Public License v2.0
2.7k stars 185 forks source link

1.1.8 Pacstall build fails #502

Closed Zahrun closed 6 months ago

Zahrun commented 6 months ago

Describe the bug

Build fails

Log

[14/18] Building CXX object CMakeFiles/obs-backgroundremoval.dir/src/enhance-filter.cpp.o
FAILED: CMakeFiles/obs-backgroundremoval.dir/src/enhance-filter.cpp.o 
/usr/bin/c++ -DHAVE_OBSCONFIG_H -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DSIMDE_ENABLE_OPENMP -Dobs_backgroundremoval_EXPORTS -I/tmp/pacstall/obs-backgroundremoval-1.1.8/build_x86_64 -I/tmp/pacstall/obs-backgroundremoval-1.1.8 -I/tmp/pacstall/obs-backgroundremoval-1.1.8/build_x86_64/obs-backgroundremoval_autogen/include -I/tmp/pacstall/obs-backgroundremoval-1.1.8/vendor/onnxruntime/include -I/tmp/pacstall/obs-backgroundremoval-1.1.8/src -isystem /tmp/pacstall/obs-backgroundremoval-1.1.8/build_x86_64/_deps/onnxruntime-src/include -isystem /usr/include/obs -isystem /usr/include/x86_64-linux-gnu/qt6/QtCore -isystem /usr/include/x86_64-linux-gnu/qt6 -isystem /usr/lib/x86_64-linux-gnu/qt6/mkspecs/linux-g++ -isystem /usr/include/x86_64-linux-gnu/qt6/QtWidgets -isystem /usr/include/x86_64-linux-gnu/qt6/QtGui -isystem /tmp/pacstall/obs-backgroundremoval-1.1.8/build_x86_64/_deps/opencv-src/include/opencv4 -O2 -g -DNDEBUG -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -fdiagnostics-color=always -fopenmp-simd -fno-strict-aliasing -Wdeprecated-declarations -Wempty-body -Wenum-conversion -Werror=return-type -Wextra -Wformat -Wformat-security -Wno-conversion -Wno-float-conversion -Wno-implicit-fallthrough -Wno-missing-braces -Wno-missing-field-initializers -Wno-shadow -Wno-sign-conversion -Wno-trigraphs -Wno-unknown-pragmas -Wno-unused-function -Wno-unused-label -Wparentheses -Wshadow -Wuninitialized -Wunreachable-code -Wunused-parameter -Wunused-value -Wunused-variable -Wvla -Wconversion -Wfloat-conversion -Winvalid-offsetof -Wno-overloaded-virtual -Wno-error=maybe-uninitialized -mmmx -msse -msse2 -std=c++17 -Werror -MD -MT CMakeFiles/obs-backgroundremoval.dir/src/enhance-filter.cpp.o -MF CMakeFiles/obs-backgroundremoval.dir/src/enhance-filter.cpp.o.d -o CMakeFiles/obs-backgroundremoval.dir/src/enhance-filter.cpp.o -c /tmp/pacstall/obs-backgroundremoval-1.1.8/src/enhance-filter.cpp
/tmp/pacstall/obs-backgroundremoval-1.1.8/src/enhance-filter.cpp: In function 'obs_properties_t* enhance_filter_properties(void*)':
/tmp/pacstall/obs-backgroundremoval-1.1.8/src/enhance-filter.cpp:85:33: error: 'OBS_TEXT_INFO' was not declared in this scope
   85 |                                 OBS_TEXT_INFO);
      |                                 ^~~~~~~~~~~~~
[15/18] Building CXX object CMakeFiles/obs-backgroundremoval.dir/src/update-checker/update-checker.cpp.o
[16/18] Building CXX object CMakeFiles/obs-backgroundremoval.dir/src/update-checker/UpdateDialog.cpp.o
[17/18] Building CXX object CMakeFiles/obs-backgroundremoval.dir/obs-backgroundremoval_autogen/mocs_compilation.cpp.o
ninja: build stopped: subcommand failed.

Desktop (please complete the following information):

Additional context

https://github.com/pacstall/pacstall-programs/pull/5075

umireon commented 6 months ago

Is your OBS version 27? OBS 27 is not supported by our latest plugin.

royshil commented 6 months ago

@umireon anyway the problem there seems like it's an #include thing Could be fixed. But yes it's not supported at OBS v27

umireon commented 6 months ago

@royshil We should not try to support v27 anymore because supporting the obsolete v27 causes a lot of problems and prevents us from using newer features of OBS. The OBS official recommends using their latest v30 distribution on PPA but doesn't mention the OBS distribution of apt on their doc. We can provide the older version of our plugin for v27 users.

Zahrun commented 6 months ago

Ok I just mentionned in the obs-backgroundremoval pacscript that jammy is not supported anymore. Anyway, the recommended pacscript is probably obs-backgroundremoval-deb which pulls your official deb instead of building manually.