search

occ-ai / obs-backgroundremoval

An OBS plugin for removing background in portrait images (video), making it easy to replace the background when recording or streaming.
GNU General Public License v2.0
2.68k stars 185 forks source link

Background removal doesn't work nicely with the Source Clone plugin from Exeldro. #554

Closed WaldoAndFriends closed 1 month ago

WaldoAndFriends commented 4 months ago

Describe the bug Background removal doesn't work nicely with the Source Clone plugin from Exeldro. When I add the background removal to a source, and make a clone of the scene where the source is in. The clone still shows the video feed with the background intact. The same is true for when I clone the source directly, the background still shows up.

To Reproduce

Steps to reproduce the behavior:

  1. Add the filter to a source
  2. Make a Source Clone of the source or scene the source is in
  3. The clone doesn't have the removed background.

Expected behavior

The source clone should be 1-to-1 the same as the original, so it should have the background removed.

Screenshots image image

Log and Crash Report log.txt

Desktop (please complete the following information):

Additional context I've also relayed this information to the developer of the Source Clone plugin

umireon commented 4 months ago

You can add this plugin to a group

WaldoAndFriends commented 4 months ago

Groups don't have the same functionality as Source Clones. As with a source clone I can create a source once and reuse it in multiple scenes, and add filters to those clones without affecting the original source or the other clones.

So perfect for stuff like a webcam that's used in multiple scenes.

umireon commented 4 months ago

Can you check if the method described in https://github.com/occ-ai/obs-backgroundremoval/issues/407 is suitable for you and if is not suitable, can you describe what is the missing feature of the group method?

umireon commented 4 months ago

I confirmed that our plugin works with Source Clone perfectly when both of the original source and the cloned source is shown. Screenshot 2024-03-09 19-40-24

umireon commented 4 months ago

@royshil I suggest that we'd like to add an option to let our plugin run the inference even if the source is not shown. What do you think?

royshil commented 3 months ago

@royshil I suggest that we'd like to add an option to let our plugin run the inference even if the source is not shown. What do you think?

sure, that's possible it can be a boolean option in the settings

github-actions[bot] commented 1 month ago

This issue is stale because it has been open for 60 days with no activity.