occ-ai / obs-backgroundremoval

An OBS plugin for removing background in portrait images (video), making it easy to replace the background when recording or streaming.
GNU General Public License v2.0
2.68k stars 186 forks source link

Huge latency issue in Linux #561

Closed yairmohr closed 3 months ago

yairmohr commented 3 months ago

Version 1.1.12 (maybe 1.1.11 too - I happened to skip from 1.1.10 to 1.1.12) seems to introduce a huge, ~1s latency to any camera feed in OBS on Linux Mint (LM version 21.3, OBS version 30.1). When I uninstalled 1.1.12 and reinstalled 1.1.10 - it was back to no latency whatsoever. It also caused OBS to take over 30s to even load.

umireon commented 3 months ago

@royshil I think we need to revert #556. That PR changes too much part of our plugin and it is hard to investigate what affects what.

umireon commented 3 months ago

I'm against stopping using video_tick. I think there are almost no benefits to use a standalone thread but it adds some complexities to our plugin.

royshil commented 3 months ago

@umireon I can revert the thread work and go back to video tick. Let me bring it up this evening

umireon commented 3 months ago

Thank you!

yairmohr commented 3 months ago

Thank you for fixing this in version 1.1.12 :+1:

royshil commented 3 months ago

Closing. Thanks!